Skip to content

release-1.3 cut details #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Conversation

mattcary
Copy link
Contributor

@mattcary mattcary commented Jul 22, 2021

/kind feature

What this PR does / why we need it:
Put 1.3.0 release into stable-master.

RC passing testgrid (visible google internal only): https://prow-gob.gcpnode.com/view/gcs/gob-prow/logs/periodic-gcp-pd-csi-driver-k8s-integration-staging/1417971893247414272

None

Change-Id: I91ea6f615b7a8e32ef4fdbb0bf0f307500416e3c
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2021
@mattcary
Copy link
Contributor Author

/assign @saikat-royc

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2021
@saikat-royc
Copy link
Member

saikat-royc commented Jul 22, 2021

FYI the prod registry does not yet have the image 1.3.0. So it needs one more cl to manually promote (sample PR

The failure in the presubmit is similar to what we are seeing in filestore presubmits also

W0722 00:25:55.434]  {
W0722 00:25:55.435]   "clientVersion": {
W0722 00:25:55.435]     "major": "1",
W0722 00:25:55.435]     "minor": "21",
W0722 00:25:55.436]     "gitVersion": "v1.21.2",
W0722 00:25:55.436]     "gitCommit": "092fbfbf53427de67cac1e9fa54aaa09a28371d7",
W0722 00:25:55.436]     "gitTreeState": "clean",
W0722 00:25:55.437]     "buildDate": "2021-06-16T12:59:11Z",
W0722 00:25:55.437]     "goVersion": "go1.16.5",
W0722 00:25:55.437]     "compiler": "gc",
W0722 00:25:55.437]     "platform": "linux/amd64"
W0722 00:25:55.437]   },
W0722 00:25:55.437]   "serverVersion": {
W0722 00:25:55.437]     "major": "1",
W0722 00:25:55.437]     "minor": "23+",
W0722 00:25:55.438]     "gitVersion": "v1.23.0-alpha.0.7+1a9ae3454993b2",
W0722 00:25:55.438]     "gitCommit": "1a9ae3454993b2362503db3efe1d7e48307bf3ff",
W0722 00:25:55.439]     "gitTreeState": "clean",
W0722 00:25:55.439]     "buildDate": "2021-07-20T19:17:27Z",
W0722 00:25:55.439]     "goVersion": "go1.16.6",
W0722 00:25:55.439]     "compiler": "gc",
W0722 00:25:55.440]     "platform": "linux/amd64"
W0722 00:25:55.440]   }
W0722 00:25:55.440] }
W0722 00:25:55.440] WARNING: version difference between client (1.21) and server (1.23) exceeds the supported minor version skew of +/-1
W0722 00:25:55.441] F0722 00:25:55.434008    3199 cluster.go:208] Error: Failed to parse kubectl version output, error: invalid character 'W' after top-level value
W0722 00:25:55.446] Traceback (most recent call last):

Json parsing is failing here due to the WARNING msg. Using Output instead of CombinedOutput() may fix this.

@mattcary
Copy link
Contributor Author

mattcary commented Jul 22, 2021 via email

@saikat-royc
Copy link
Member

The order is correct

@mattcary
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@mattcary: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration 6cb85e6 link /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mattcary
Copy link
Contributor Author

Known flake, force-submitting.

@mattcary mattcary merged commit 82070d8 into kubernetes-sigs:master Jul 22, 2021
@mattcary mattcary deleted the release-1.3-cut branch July 22, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants